chore: remove lfx-bundles from default Langflow install#13869
Open
erichare wants to merge 8 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughDocumentation, package metadata, tests, and compatibility shims now describe ChangesBundle guidance normalization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 8 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.11.0 #13869 +/- ##
==================================================
- Coverage 59.79% 59.45% -0.34%
==================================================
Files 2347 2240 -107
Lines 224750 221387 -3363
Branches 33483 30522 -2961
==================================================
- Hits 134389 131634 -2755
+ Misses 88827 88220 -607
+ Partials 1534 1533 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (8)
src/lfx/src/lfx/components/vlmrun/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
Normalize spacing to
"Install it with: pip install lfx-bundles."(single space after colon) for consistency with docs and tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/vlmrun/__init__.py` around lines 16 - 19, The error message in the vlmrun import notice has an extra space after the colon in the install instruction. Update the message in the __init__ module for the vlmrun components so the text uses a single space after "Install it with:" and matches the expected docs/tests wording, keeping the rest of the message unchanged.src/lfx/src/lfx/components/wikipedia/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
Normalize spacing to
"Install it with: pip install lfx-bundles."(single space after colon) for consistency with docs and tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/wikipedia/__init__.py` around lines 16 - 19, The wikipedia import error message in the __init__ module has inconsistent spacing after the colon; update the msg string so the install instruction uses a single space before the pip command. Keep the change localized to the wikipedia components message text so it matches the expected docs and tests.src/lfx/src/lfx/components/langwatch/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
Normalize spacing to
"Install it with: pip install lfx-bundles."(single space after colon) for consistency with docs and tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/langwatch/__init__.py` around lines 16 - 19, The error message in the langwatch import path has inconsistent spacing after the colon in the install instruction. Update the message built in the langwatch component initializer to use the normalized wording with a single space after “Install it with:” so it matches docs and tests; locate it via the langwatch __init__ message string.src/lfx/src/lfx/components/weaviate/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
Normalize spacing to
"Install it with: pip install lfx-bundles."(single space after colon) for consistency with docs and tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/weaviate/__init__.py` around lines 16 - 19, The error message in the weaviate components import path has an extra space after the colon, so update the message built in the __init__.py fallback text to use a single space in the “Install it with:” phrase. Keep the rest of the message unchanged and ensure the string emitted by the weaviate module matches the documented and tested wording exactly.src/lfx/src/lfx/components/jigsawstack/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
Normalize spacing to
"Install it with: pip install lfx-bundles."(single space after colon) for consistency with docs and tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/jigsawstack/__init__.py` around lines 16 - 19, The error message in the jigsawstack module has inconsistent spacing after the colon in the install instruction. Update the message in the __init__ path for the jigsawstack components so the text reads with a single space after “Install it with:” and keep the rest of the message unchanged to match docs and tests.src/lfx/src/lfx/components/huggingface/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
Same spacing inconsistency as noted in
homeassistant/__init__.py: the message has two spaces after the colon. Normalize to"Install it with: pip install lfx-bundles."for consistency with documentation and tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/huggingface/__init__.py` around lines 16 - 19, The error message in the huggingface components’ module-level `msg` string has an extra space after the colon in the install instruction. Update the message in `lfx/components/huggingface/__init__.py` so the text in that string uses the same normalized spacing as the other component messages, keeping the `msg` assignment consistent and matching the expected wording.src/lfx/src/lfx/components/icosacomputing/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
Normalize spacing to
"Install it with: pip install lfx-bundles."(single space after colon) for consistency with docs and tests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/icosacomputing/__init__.py` around lines 16 - 19, The import error message in the icosacomputing package has inconsistent spacing after the colon in the install hint. Update the message string in the __init__ module for the icosacomputing components so the “Install it with:” text uses a single space before “pip install lfx-bundles.” to match docs and tests.src/lfx/src/lfx/components/homeassistant/__init__.py (1)
16-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winFix double space in error message.
The error message contains two spaces after the colon (
"Install it with: pip install lfx-bundles."), which is inconsistent with the documented format showing a single space ("Install it with: pip install lfx-bundles.") indocs/docs/Develop/extensions-overview.mdx:77-90and the test regex pattern insrc/lfx/tests/unit/components/test_bundle_shims.py:303-313. Please normalize to a single space for consistency.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lfx/src/lfx/components/homeassistant/__init__.py` around lines 16 - 19, The homeassistant shim error message in the module that defines msg has an extra space after the colon in the install instruction. Update the message text to use a single space in the “Install it with:” phrase so it matches the documented format and the bundle shim test expectations, keeping the wording consistent in the homeassistant component initializer.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/lfx/src/lfx/components/homeassistant/__init__.py`:
- Around line 16-19: The homeassistant shim error message in the module that
defines msg has an extra space after the colon in the install instruction.
Update the message text to use a single space in the “Install it with:” phrase
so it matches the documented format and the bundle shim test expectations,
keeping the wording consistent in the homeassistant component initializer.
In `@src/lfx/src/lfx/components/huggingface/__init__.py`:
- Around line 16-19: The error message in the huggingface components’
module-level `msg` string has an extra space after the colon in the install
instruction. Update the message in `lfx/components/huggingface/__init__.py` so
the text in that string uses the same normalized spacing as the other component
messages, keeping the `msg` assignment consistent and matching the expected
wording.
In `@src/lfx/src/lfx/components/icosacomputing/__init__.py`:
- Around line 16-19: The import error message in the icosacomputing package has
inconsistent spacing after the colon in the install hint. Update the message
string in the __init__ module for the icosacomputing components so the “Install
it with:” text uses a single space before “pip install lfx-bundles.” to match
docs and tests.
In `@src/lfx/src/lfx/components/jigsawstack/__init__.py`:
- Around line 16-19: The error message in the jigsawstack module has
inconsistent spacing after the colon in the install instruction. Update the
message in the __init__ path for the jigsawstack components so the text reads
with a single space after “Install it with:” and keep the rest of the message
unchanged to match docs and tests.
In `@src/lfx/src/lfx/components/langwatch/__init__.py`:
- Around line 16-19: The error message in the langwatch import path has
inconsistent spacing after the colon in the install instruction. Update the
message built in the langwatch component initializer to use the normalized
wording with a single space after “Install it with:” so it matches docs and
tests; locate it via the langwatch __init__ message string.
In `@src/lfx/src/lfx/components/vlmrun/__init__.py`:
- Around line 16-19: The error message in the vlmrun import notice has an extra
space after the colon in the install instruction. Update the message in the
__init__ module for the vlmrun components so the text uses a single space after
"Install it with:" and matches the expected docs/tests wording, keeping the rest
of the message unchanged.
In `@src/lfx/src/lfx/components/weaviate/__init__.py`:
- Around line 16-19: The error message in the weaviate components import path
has an extra space after the colon, so update the message built in the
__init__.py fallback text to use a single space in the “Install it with:”
phrase. Keep the rest of the message unchanged and ensure the string emitted by
the weaviate module matches the documented and tested wording exactly.
In `@src/lfx/src/lfx/components/wikipedia/__init__.py`:
- Around line 16-19: The wikipedia import error message in the __init__ module
has inconsistent spacing after the colon; update the msg string so the install
instruction uses a single space before the pip command. Keep the change
localized to the wikipedia components message text so it matches the expected
docs and tests.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 45e19819-dab0-4b68-81d8-0625f5bcfaaa
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (81)
docs/docs/Deployment/deployment-lfx-compatibility.mdxdocs/docs/Develop/extensions-overview.mdxpyproject.tomlscripts/migrate/consolidate_bundles.pysrc/backend/base/langflow/locales/en.jsonsrc/backend/tests/unit/test_lfx_bundles_extras.pysrc/bundles/lfx-bundles/README.mdsrc/bundles/lfx-bundles/pyproject.tomlsrc/lfx/src/lfx/components/FAISS/__init__.pysrc/lfx/src/lfx/components/Notion/__init__.pysrc/lfx/src/lfx/components/agentql/__init__.pysrc/lfx/src/lfx/components/aiml/__init__.pysrc/lfx/src/lfx/components/altk/__init__.pysrc/lfx/src/lfx/components/apify/__init__.pysrc/lfx/src/lfx/components/assemblyai/__init__.pysrc/lfx/src/lfx/components/azure/__init__.pysrc/lfx/src/lfx/components/baidu/__init__.pysrc/lfx/src/lfx/components/bing/__init__.pysrc/lfx/src/lfx/components/chroma/__init__.pysrc/lfx/src/lfx/components/cleanlab/__init__.pysrc/lfx/src/lfx/components/clickhouse/__init__.pysrc/lfx/src/lfx/components/cloudflare/__init__.pysrc/lfx/src/lfx/components/codeagents/__init__.pysrc/lfx/src/lfx/components/cometapi/__init__.pysrc/lfx/src/lfx/components/composio/__init__.pysrc/lfx/src/lfx/components/confluence/__init__.pysrc/lfx/src/lfx/components/couchbase/__init__.pysrc/lfx/src/lfx/components/cuga/__init__.pysrc/lfx/src/lfx/components/deepseek/__init__.pysrc/lfx/src/lfx/components/elastic/__init__.pysrc/lfx/src/lfx/components/exa/__init__.pysrc/lfx/src/lfx/components/git/__init__.pysrc/lfx/src/lfx/components/glean/__init__.pysrc/lfx/src/lfx/components/google/__init__.pysrc/lfx/src/lfx/components/groq/__init__.pysrc/lfx/src/lfx/components/homeassistant/__init__.pysrc/lfx/src/lfx/components/huggingface/__init__.pysrc/lfx/src/lfx/components/icosacomputing/__init__.pysrc/lfx/src/lfx/components/jigsawstack/__init__.pysrc/lfx/src/lfx/components/langwatch/__init__.pysrc/lfx/src/lfx/components/litellm/__init__.pysrc/lfx/src/lfx/components/lmstudio/__init__.pysrc/lfx/src/lfx/components/maritalk/__init__.pysrc/lfx/src/lfx/components/mem0/__init__.pysrc/lfx/src/lfx/components/milvus/__init__.pysrc/lfx/src/lfx/components/mistral/__init__.pysrc/lfx/src/lfx/components/mongodb/__init__.pysrc/lfx/src/lfx/components/needle/__init__.pysrc/lfx/src/lfx/components/notdiamond/__init__.pysrc/lfx/src/lfx/components/novita/__init__.pysrc/lfx/src/lfx/components/nvidia/__init__.pysrc/lfx/src/lfx/components/olivya/__init__.pysrc/lfx/src/lfx/components/ollama/__init__.pysrc/lfx/src/lfx/components/openrouter/__init__.pysrc/lfx/src/lfx/components/perplexity/__init__.pysrc/lfx/src/lfx/components/pgvector/__init__.pysrc/lfx/src/lfx/components/pinecone/__init__.pysrc/lfx/src/lfx/components/qdrant/__init__.pysrc/lfx/src/lfx/components/redis/__init__.pysrc/lfx/src/lfx/components/sambanova/__init__.pysrc/lfx/src/lfx/components/scrapegraph/__init__.pysrc/lfx/src/lfx/components/searchapi/__init__.pysrc/lfx/src/lfx/components/serpapi/__init__.pysrc/lfx/src/lfx/components/spider/__init__.pysrc/lfx/src/lfx/components/supabase/__init__.pysrc/lfx/src/lfx/components/tavily/__init__.pysrc/lfx/src/lfx/components/twelvelabs/__init__.pysrc/lfx/src/lfx/components/unstructured/__init__.pysrc/lfx/src/lfx/components/upstash/__init__.pysrc/lfx/src/lfx/components/vectara/__init__.pysrc/lfx/src/lfx/components/vectorstores/__init__.pysrc/lfx/src/lfx/components/vertexai/__init__.pysrc/lfx/src/lfx/components/vllm/__init__.pysrc/lfx/src/lfx/components/vlmrun/__init__.pysrc/lfx/src/lfx/components/weaviate/__init__.pysrc/lfx/src/lfx/components/wikipedia/__init__.pysrc/lfx/src/lfx/components/wolframalpha/__init__.pysrc/lfx/src/lfx/components/xai/__init__.pysrc/lfx/src/lfx/components/yahoosearch/__init__.pysrc/lfx/src/lfx/components/youtube/__init__.pysrc/lfx/src/lfx/components/zep/__init__.py
Contributor
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
This comment has been minimized.
This comment has been minimized.
erichare
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Build successful! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lfx-bundles[all]from the rootlangflowdependencies and lock metadata so it is not installed by default.lfx-bundlesin the workspace and available as explicit opt-in vialfx[bundles]/lfx-bundles[all].lfx-bundlesexplicitly.Tests
uv lock --frozenuv tree --frozen --no-dev --package langflow --depth 1uv run --frozen pytest src/backend/tests/unit/test_lfx_bundles_extras.py src/backend/tests/unit/api/test_api_utils.py -qcd src/lfx && uv sync && uv run pytest tests/unit/components/test_bundle_shims.py tests/unit/utils/test_exceptions.py -qSummary by CodeRabbit
Documentation
Bug Fixes
pip install lfx-bundlesinstruction without confusing alternate guidance or extra spacing.