create-implementation-plan: require unique identifiers (#1989)#2142
Open
KomalSrinivasan wants to merge 2 commits into
Open
create-implementation-plan: require unique identifiers (#1989)#2142KomalSrinivasan wants to merge 2 commits into
KomalSrinivasan wants to merge 2 commits into
Conversation
The skill template tells the agent to use REQ-, TASK-, GOAL-, and similar prefixed identifiers, but never says they have to be unique or how to check. @basilevs reported plans coming back with duplicate TASK IDs and proposed three POSIX one-liners that catch the two real collision modes (table rows and bullet declarations) plus a broad diagnostic scan. Document the uniqueness rule under the existing Template Validation Rules, then add a new "Identifier Uniqueness Check" section with all three bash commands and instructions on which must come back empty before the plan is finalized. DEP-* references intentionally allowed in multiple sections per the reporter's note. Closes github#1989.
Contributor
🔒 PR Risk Scan ResultsScanned 2 changed file(s).
|
Contributor
🔍 Skill Validator Results
Summary
Full validator output |
Contributor
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
|
|
Upstream skills/create-implementation-plan/SKILL.md already uses GUD-001 in the template body. Codespell currently slips past it on word-boundary, but the regex alternation (GUD|RISK|...) added in the previous commit on this branch makes codespell flag it as a misspelling of GOOD. GUD is the documented "Guideline" identifier prefix alongside REQ, SEC, CON, PAT, etc. Add it to the ignore-words-list, matching the pattern every other technical-token exemption in .codespellrc uses.
Contributor
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1989.
@basilevs reported that the
create-implementation-planskill occasionally produces plans with duplicateTASK-identifiers (and could just as easily collide onREQ-,GOAL-, etc.). The skill template defines the prefix scheme but doesn't say identifiers must be unique, and gives the agent no way to verify.The reporter already worked out the right checks. This PR drops them into the skill.
Changes
skills/create-implementation-plan/SKILL.mdpicks up:A new bullet under
Template Validation Rules: identifiers must be declared exactly once across the plan.DEP-*is called out as the deliberate exception because it commonly appears as a reference in both Requirements and Dependencies.A new
Identifier Uniqueness Checksection with the reporter's three POSIX one-liners:TASK/GOALdeclarations in table rows.Checks 1 and 2 must return empty before finalizing. The section also notes the POSIX prereqs and what to substitute on Windows.
Why this shape
Template Validation Ruleskeeps it visible at the same scan depth as the other invariants.Verification
npm run skill:validatereportscreate-implementation-planas valid.npm run buildexits 0, regeneratesmarketplace.json.